OpenWeatherMap Demo Application
25-Jan-2018 - Following a 'code review', this mini project was a three day setup and see if it works prototype.
So, a quick revisit to identify separations of concerns, redesigned as OOD, to some degree.
Still not happy with HTML strings in the controller, but:
1. It works;
2. Easy to understand.
If this was moved into the View, it would require 'if' statements which is frowned upon (bad coding smell).
Conclusion: Not worth any more effort at this time.
23-Jan-2018 - DDL issue with HiddenFor is not a bug - my mistake (doh!). Where I have used it is in Edit/Delete views to capture non-displayed primary keys.
16-Jan-2018 - Updated to only load city data once.
15-Jan-2018 - "Fix" issue with DDL.
- The statements made below marked as [NOT TRUE] as they are not true - can specify a single field to hold the item value from a DDL.
- The "Fix" was to remove the
@Html.HiddenFor(model => model.cityid) and that sorted it out i.e. I get the value I need where I want it to be stored.
- ....BUT, I have another system where the HiddenFor IS required, so still think there's a bug in VS.
13-Jan-2018 - Investigate issue with DDL.
- [NOT TRUE] Turns out the required action is to specify a target that has the same 'structure' as the list i.e. it's not the value that is 'returned', it's the value and the text.
- [NOT TRUE]...and by chance, the m.citylist[0].id will have the same address as m.citylist[0], so either should suffice..but NO, m.citylist[0] => Invalid Model.
- Tested with a { id, name } class, but that came back invalid also...so still not convinced on what it is doing...
12-Jan-2018 - Day 3 Completed!!!
- Implemented search and only use the DDL for found cities.
- Single column output for forecast data.
- Verified and fixed class structures xf OWM docs.
- Fixed "3h" rain/snow field mapping.
11-Jan-2018 - Day 2
- API call for 5 day Forecast
- Generate table html for forecast results
- Add Weather Map Layers - shelved as broken on service provider = revert to standard map link
- Graphics = no - need $1650 to have these
10-Jan-2018 - The Brief: Technical Exercise - Using the OpenWeatherMap API https://openweathermap.org create an application which demonstrates your technical abilities as a developer.
OK - what to do? On looking at the OWM website, there is an API menu option which opens up a page:
"Our weather API is simple, clear and free. We also offer higher levels of support, please see our paid plan options.
To access the API you need to sign up for an API key if you are on a free or paid plan."
After a bit of reading, followed the instructions and signed up for a free API key.
"Call API by city ID instead of city name, city coordinates or zip code. In this case you get precise respond exactly for your city. The cities' IDs can be found in the following file: Cities' IDs list."
Starting Point - download, unzip and see what's in the file!
First Steps:
- Create a new C# MVC template project to build my prototype.
- Download, unzip the city file - JSON format
- Import the city file
- Test page for Select a City and to action a request for one city
- Get the results of the request into a usable format (class structures)
- Display results on screen (view)
Simple!
Well, not quite. 1, 2 & 3 went really smoothly, even the file load.
Point 3: Wow - too many records in the city data for a drop-down-list.
Point 4: Split-decision = press on, but only list city data in country 'GB' beginning with 'H'.
Point 5: Class Structures - chored for now - see if it works.
Works!
Point 5: Oh Dear!
The story goes like this...
Set up the template for C# MVC.
Loaded the city file into a city class.
Passed this to my view ok.
Tested the current weather api call and got the response ok.
Added a ddl to my view to list a limited number of cities from the loaded city file...
...seems to be a major problem as the model is coming back from the view as invalid.
Several hours later, I have found the problem and a solution, but still smacks of a bug in VS:
In my view, the plan was to have an id to capture the selected id of the city selected from the ddl i.e. I have:
@Html.HiddenFor(model => model.cityid)
...
@Html.DropDownListFor(m => m.cityid, new SelectList(Model.citylist, "id", "name"), "Select...", new { @class = "form-control", id = "CityDDLDiv" })
But this value comes back as null and the model is invalid
After much searching and testing, this is the only thing that worked:
@Html.DropDownListFor(m => m.citylist[0].id, new SelectList(Model.citylist, "id", "name"), "Select...", new { @class = "form-control", id = "CityDDLDiv" })
Anyway, it's working and the response has been decoded and I have the data on screen :-)